This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Dismiss the login select prompt when navigating away #9229
Assignees
Comments
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Dec 15, 2020
…o another tab This would ensure GV will trigger this prompt type for the new tab even if there is (was) already such a prompt shown in the previous tab. Upon returning to the previous tab which now has the login select prompt dismissed users just have to focus any login fields for GV to trigger showing again the login prompt.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Dec 15, 2020
…ompt convenience method
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Dec 16, 2020
…o another tab This would ensure GV will trigger this prompt type for the new tab even if there is (was) already such a prompt shown in the previous tab. Upon returning to the previous tab which now has the login select prompt dismissed users just have to focus any login fields for GV to trigger showing again the login prompt.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Dec 16, 2020
…ompt convenience method
mergify bot
pushed a commit
that referenced
this issue
Dec 16, 2020
This would ensure GV will trigger this prompt type for the new tab even if there is (was) already such a prompt shown in the previous tab. Upon returning to the previous tab which now has the login select prompt dismissed users just have to focus any login fields for GV to trigger showing again the login prompt.
|
Verified as fixed on Fenix - mozilla-mobile/fenix#16182 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When opening a new page GV would scan the structure and if there is a login field it would call
onLoginSelectallowing clients to either let GV immediately autocomple or allow users first selecting which login to use.What I think mozilla-mobile/fenix#16182 (comment) shown is that GV would not call
onLoginSelectagain until the previous such call was resolved.And IRL it is possible that the user gets to see a login select dialog but before proceeding with logging in it navigates to another page which again should present such a dialog.
As an easy workaround for the above scenario we can dismiss the current login select prompt when the user navigates away such that upon opening a new tab GV will again trigger the login select prompt.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: