This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Issue #10836: Add Facts for Credit Card Autofill Feature #10837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocketsroger
added
work in progress
rocketsroger
removed
the
<autofill>
3 tasks
rocketsroger
force-pushed
the
AC_10836
branch
2 times, most recently
from
a7804a7
to
bcea682
Compare
rocketsroger
removed
the
work in progress
Amejia481
reviewed
Aug 19, 2021
| @@ -424,6 +425,7 @@ class PromptFeature private constructor( | |||
| is File -> filePicker.handleFileRequest(promptRequest) | |||
| is Share -> handleShareRequest(promptRequest, session) | |||
| is SelectCreditCard -> { | |||
| emitSuccessfulCreditCardAutofillFormDetectedFact() | |||
There was a problem hiding this comment.
Should this be inside of if below line 429?
There was a problem hiding this comment.
No, we still want to emit the fact even if credit card autofill is disabled or there is not credit card stored. The reason is the fact is just to show that we've detected a credit card autofill form.
Amejia481
approved these changes
Sep 1, 2021
rocketsroger
added
🛬 needs landing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge