This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
For #12804 - Catch the exception when querying activities #12807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts when rebasing. Could you fix it @Mugurell? 🙏 |
| return try { | ||
| context.packageManager | ||
| .queryIntentActivities(intent, PackageManager.GET_RESOLVED_FILTER) | ||
| } catch (e: RuntimeException) { |
There was a problem hiding this comment.
I'm not sure about this. The documentation doesn't show that it can throw an error. Do we have any crash reporting that tells us what error it could be throwing?
There was a problem hiding this comment.
I see the original issue. Maybe we just catch the TransactionTooLargeException exception?
There was a problem hiding this comment.
Based on the report from mozilla-mobile/fenix#27042 it seems to me like there is a RuntimeException wrapping the TransactionTooLargeException?
|
This pull request has conflicts when rebasing. Could you fix it @Mugurell? 🙏 |
csadilek
approved these changes
Oct 11, 2022
Mugurell
force-pushed
the
appLinksCrash
branch
from
ce317d1
to
220ddf8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speculative fix. A simple try-catch over an error that we cannot do anything else about.
Pull Request checklist
After merge
GitHub Automation
Fixes #12804