Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Glean: Re-export TextMetricType & RateMetricType #13010

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Glean: Re-export TextMetricType & RateMetricType #13010

merged 3 commits into from
Oct 26, 2022

Conversation

badboy
Copy link
Member

@badboy badboy commented Oct 26, 2022

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

GitHub Automation

Used by GitHub Actions.

@badboy badboy requested a review from a team as a code owner October 26, 2022 09:54
@badboy badboy mentioned this pull request Oct 26, 2022
Merged
4 tasks
Dexterp37
Dexterp37 approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs a changelog entry. r+wc

@badboy badboy added the 🛬 needs landing PRs that are ready to land label Oct 26, 2022
mcarare
mcarare reviewed Oct 26, 2022
View reviewed changes
docs/changelog.md Outdated Show resolved Hide resolved
@mergify mergify bot merged commit 184adc3 into mozilla-mobile:main Oct 26, 2022
@badboy badboy deleted the reexport-text-metric-type branch October 26, 2022 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcarare mcarare mcarare left review comments

@Dexterp37 Dexterp37 Dexterp37 approved these changes

Assignees
No one assigned
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@badboy @Dexterp37 @mcarare