Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Revert "Closes #5284: Adds progress bar to downloads" #5427

Merged
merged 1 commit into from
Dec 30, 2019

Conversation

jonalmeida
Copy link
Contributor

This reverts commit fb3847f.

Reverting due to failing CI builds.


cc: @sblatz

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

This reverts commit fb3847f.

Reverting due to failing CI builds.
@codecov
Copy link

codecov bot commented Dec 30, 2019

Codecov Report

Merging #5427 into master will increase coverage by 0.31%.
The diff coverage is 79.31%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5427      +/-   ##
============================================
+ Coverage     79.92%   80.23%   +0.31%     
- Complexity     3983     4222     +239     
============================================
  Files           510      545      +35     
  Lines         18504    19112     +608     
  Branches       2682     2775      +93     
============================================
+ Hits          14789    15335     +546     
- Misses         2602     2618      +16     
- Partials       1113     1159      +46
Impacted Files Coverage Δ Complexity Δ
...mponents/feature/downloads/DownloadNotification.kt 70.32% <100%> (+70.32%) 9 <0> (+9) ⬆️
.../feature/downloads/AbstractFetchDownloadService.kt 47.19% <77.77%> (+2.45%) 22 <11> (ø) ⬇️
...components/support/sync/telemetry/SyncTelemetry.kt 91.08% <0%> (-0.92%) 34% <0%> (ø)
...ozilla/components/browser/errorpages/ErrorPages.kt
...a/mozilla/components/concept/push/PushProcessor.kt
...lla/components/support/base/observer/Consumable.kt 100% <0%> (ø) 12% <0%> (?)
...ava/mozilla/components/feature/pwa/ext/Activity.kt 100% <0%> (ø) 0% <0%> (?)
...upport/base/facts/processor/CollectionProcessor.kt 0% <0%> (ø) 0% <0%> (?)
...ts/support/base/feature/ViewBoundFeatureWrapper.kt 87.5% <0%> (ø) 16% <0%> (?)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 202f6d4...14e0c6b. Read the comment docs.

Copy link
Contributor

@rocketsroger rocketsroger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rocketsroger
Copy link
Contributor

bors r+

bors bot pushed a commit that referenced this pull request Dec 30, 2019
5427: Revert "Closes #5284: Adds progress bar to downloads" r=rocketsroger a=jonalmeida

This reverts commit fb3847f.

Reverting due to failing CI builds.



Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
@bors
Copy link

bors bot commented Dec 30, 2019

Build succeeded

  • complete-push

@bors bors bot merged commit 14e0c6b into mozilla-mobile:master Dec 30, 2019
@jonalmeida jonalmeida deleted the revert-5285 branch December 30, 2019 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants