Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Issue #2985: Support loading reader view ext. page in new session #6906

Merged
merged 1 commit into from
May 7, 2020

Conversation

csadilek
Copy link
Contributor

@csadilek csadilek commented May 7, 2020

Basically, a leftover from the refactoring. We used to turn on reader mode when the port connected and reader mode was active for this session. Now we have a separate page which could be loaded in a new session. When the reader extension page connect, we can simply "show" reader mode (and mark it as active for the session, but that part already worked.)

Copy link
Contributor

@jonalmeida jonalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! ⚡

@csadilek
Copy link
Contributor Author

csadilek commented May 7, 2020

bors r=jonalmeida

@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #6906 into master will decrease coverage by 0.11%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6906      +/-   ##
============================================
- Coverage     77.32%   77.21%   -0.12%     
+ Complexity     4816     4722      -94     
============================================
  Files           646      634      -12     
  Lines         23569    23161     -408     
  Branches       3469     3413      -56     
============================================
- Hits          18225    17883     -342     
+ Misses         3894     3854      -40     
+ Partials       1450     1424      -26     
Impacted Files Coverage Δ Complexity Δ
...components/feature/readerview/ReaderViewFeature.kt 80.23% <80.00%> (+2.07%) 26.00 <1.00> (+1.00)
...onents/support/sync/telemetry/BaseGleanSyncPing.kt 100.00% <0.00%> (ø) 11.00% <0.00%> (ø%)
...s/support/webextensions/facts/WebExtensionFacts.kt
...nents/support/webextensions/WebExtensionSupport.kt
...ts/feature/syncedtabs/storage/SyncedTabsStorage.kt
...fetch/httpurlconnection/HttpURLConnectionClient.kt
...ts/support/webextensions/WebExtensionController.kt
.../syncedtabs/SyncedTabsStorageSuggestionProvider.kt
.../support/webextensions/WebExtensionPopupFeature.kt
...s/feature/syncedtabs/presenter/DefaultPresenter.kt
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb975c...3b8908f. Read the comment docs.

@bors
Copy link

bors bot commented May 7, 2020

Build succeeded:

@bors bors bot merged commit 246fc69 into mozilla-mobile:master May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants