This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 473
🎲 For #6907 - Dispatches tabsTray update when MediaState changes. #6908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6908 +/- ##
============================================
+ Coverage 77.08% 77.10% +0.02%
+ Complexity 4868 4750 -118
============================================
Files 652 630 -22
Lines 23987 23628 -359
Branches 3512 3474 -38
============================================
- Hits 18490 18218 -272
+ Misses 4038 3965 -73
+ Partials 1459 1445 -14
Continue to review full report at Codecov.
|
gabrielluong
reviewed
May 8, 2020
...feature/tabs/src/test/java/mozilla/components/feature/tabs/tabstray/TabsTrayPresenterTest.kt
Outdated
Show resolved
Hide resolved
jonalmeida
reviewed
May 8, 2020
...nts/feature/tabs/src/main/java/mozilla/components/feature/tabs/tabstray/TabsTrayPresenter.kt
Outdated
Show resolved
Hide resolved
...nts/feature/tabs/src/main/java/mozilla/components/feature/tabs/tabstray/TabsTrayPresenter.kt
Outdated
Show resolved
Hide resolved
- Maps MediaState from BrowserState when creating the Tabs list
boek
changed the title
For #6907 - Dispatches tabsTray update when MediaState changes.
🎲 For #6907 - Dispatches tabsTray update when MediaState changes.
May 12, 2020
jonalmeida
approved these changes
May 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⏯️
csadilek
approved these changes
May 12, 2020
bors r=jonalmeida,csadilek |
Timed out. |
jonalmeida
added
🛬 needs landing
PRs that are ready to land
and removed
🕵️♀️ needs review
PRs that need to be reviewed
labels
May 12, 2020
bors retry |
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6907
Pull Request checklist
After merge