Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

🎲 For #6907 - Dispatches tabsTray update when MediaState changes. #6908

Merged
merged 3 commits into from
May 13, 2020

Conversation

boek
Copy link
Contributor

@boek boek commented May 7, 2020

Fixes #6907


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@boek boek requested review from csadilek and jonalmeida May 7, 2020 20:55
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #6908 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6908      +/-   ##
============================================
+ Coverage     77.08%   77.10%   +0.02%     
+ Complexity     4868     4750     -118     
============================================
  Files           652      630      -22     
  Lines         23987    23628     -359     
  Branches       3512     3474      -38     
============================================
- Hits          18490    18218     -272     
+ Misses         4038     3965      -73     
+ Partials       1459     1445      -14     
Impacted Files Coverage Δ Complexity Δ
...ozilla/components/feature/tabs/ext/BrowserState.kt 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...lla/components/feature/tabs/ext/TabSessionState.kt 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...ponents/feature/tabs/tabstray/TabsTrayPresenter.kt 93.93% <100.00%> (ø) 9.00 <1.00> (ø)
...components/support/base/log/sink/AndroidLogSink.kt
.../components/support/base/coroutines/Dispatchers.kt
...in/java/mozilla/components/support/base/log/Log.kt
...mozilla/components/support/base/android/Padding.kt
...java/mozilla/components/support/base/facts/Fact.kt
...lla/components/support/base/ids/SharedIdsHelper.kt
...ts/support/base/feature/ViewBoundFeatureWrapper.kt
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99e1445...3dc55a7. Read the comment docs.

@boek boek linked an issue May 8, 2020 that may be closed by this pull request
@boek boek changed the title For #6907 - Dispatches tabsTray update when MediaState changes. 🎲 For #6907 - Dispatches tabsTray update when MediaState changes. May 12, 2020
Copy link
Contributor

@jonalmeida jonalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏯️

@jonalmeida
Copy link
Contributor

bors r=jonalmeida,csadilek

bors bot pushed a commit that referenced this pull request May 12, 2020
6908: 🎲 For #6907 - Dispatches tabsTray update when MediaState changes. r=jonalmeida,csadilek a=boek



Co-authored-by: Jeff Boek <jeff@jeffboek.com>
@bors
Copy link

bors bot commented May 12, 2020

Timed out.

@jonalmeida jonalmeida added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels May 12, 2020
@jonalmeida
Copy link
Contributor

bors retry

@bors
Copy link

bors bot commented May 13, 2020

Build succeeded:

@bors bors bot merged commit 11940fb into mozilla-mobile:master May 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tab tray when MediaState changes
5 participants