Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Long delay when swiping to close tabs with many tabs open (~100 tabs) #11352

Closed
robsmith11 opened this issue Jun 9, 2020 · 8 comments
Closed
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Tabs performance Possible performance wins

Comments

@robsmith11
Copy link

robsmith11 commented Jun 9, 2020

We repurposed this issue to address from #11352 (comment)

After further use, it seems the slowdown is only obvious when a large (~100) number of tabs is open.

There's the same 1.5 second delay every time one swipes a tab to close it.


The new tab from the latest Nightly is very slow. It opens quickly but then takes a full 1.5 seconds for the thumbnails to display, which is a major regression.

Device has Android 10 and a Kirin 980.

┆Issue is synchronized with this Jira Task

@robsmith11 robsmith11 added the 🐞 bug Crashes, Something isn't working, .. label Jun 9, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 9, 2020
@gabrielluong gabrielluong added Skittle performance Possible performance wins Feature:Tabs and removed needs:triage Issue needs triage labels Jun 9, 2020
@robsmith11
Copy link
Author

After further use, it seems the slowdown is only obvious when a large (~100) number of tabs is open.

There's the same 1.5 second delay every time one swipes a tab to close it.

@mcomella mcomella changed the title [Bug] The new tab tray is much slower [Bug] Improve performance of async tab loading on tabs tray Jun 10, 2020
@mcomella mcomella changed the title [Bug] Improve performance of async tab loading on tabs tray [Bug] The new tabs tray is much slower Jun 10, 2020
@mcomella
Copy link
Contributor

It opens quickly but then takes a full 1.5 seconds for the thumbnails to display, which is a major regression.

This should be addressed by #11185.

There's the same 1.5 second delay every time one swipes a tab to close it.

I will repurpose this issue to investigate and address this performance problem.

@mcomella mcomella changed the title [Bug] The new tabs tray is much slower [Bug] Long delay when swiping to close tabs with many tabs open (~100 tabs) Jun 10, 2020
@mcomella
Copy link
Contributor

Anecdotally, I saw this issue on Nightly 200609 (Preview channel) but not on Nightly 200610 (fennecNightly, fresh install) – I wonder if it's been fixed.

@mcomella
Copy link
Contributor

Triage: we should determine at home many tabs does the delay become a problem.

@mcomella
Copy link
Contributor

See also #11438

@mcomella mcomella self-assigned this Jun 16, 2020
@mcomella
Copy link
Contributor

mcomella commented Jun 16, 2020

I can no longer reproduce this on 200616 Nightly (I double-checked I could reproduce on 200610 and used the same installed data to do so). To be fair, I could never reliably reproduce this anyway. I suspect mozilla-mobile/android-components#7313 fixed the issue. Please reopen if you can still reproduce on the latest Nightly (and I'll keep an eye out for it too).

@robsmith11
Copy link
Author

Yes, the delay seems to be fixed.

There's now a new problem: to switch tabs, one must always tap the thumbnail twice (first tap is ignored), but I guess that should be in a new issue.

@cadeyrn
Copy link
Contributor

cadeyrn commented Jun 17, 2020

@robsmith11 This will be fixed in the next Nightly build.

@data-sync-user data-sync-user changed the title [Bug] Long delay when swiping to close tabs with many tabs open (~100 tabs) FNX2-16469 ⁃ [Bug] Long delay when swiping to close tabs with many tabs open (~100 tabs) Aug 1, 2020
@data-sync-user data-sync-user changed the title FNX2-16469 ⁃ [Bug] Long delay when swiping to close tabs with many tabs open (~100 tabs) FNX3-14572 ⁃ [Bug] Long delay when swiping to close tabs with many tabs open (~100 tabs) Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-14572 ⁃ [Bug] Long delay when swiping to close tabs with many tabs open (~100 tabs) FNX-12267 ⁃ [Bug] Long delay when swiping to close tabs with many tabs open (~100 tabs) Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12267 ⁃ [Bug] Long delay when swiping to close tabs with many tabs open (~100 tabs) FNX2-16469 ⁃ [Bug] Long delay when swiping to close tabs with many tabs open (~100 tabs) Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16469 ⁃ [Bug] Long delay when swiping to close tabs with many tabs open (~100 tabs) [Bug] Long delay when swiping to close tabs with many tabs open (~100 tabs) May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Tabs performance Possible performance wins
Projects
None yet
Development

No branches or pull requests

5 participants