Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Download of Rules or Settings from uBlock Origin fails #16228

Closed
Dan884 opened this issue Oct 28, 2020 · 6 comments
Closed

Download of Rules or Settings from uBlock Origin fails #16228

Dan884 opened this issue Oct 28, 2020 · 6 comments
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Download Feature:WebExtensions

Comments

@Dan884
Copy link

Dan884 commented Oct 28, 2020 •
edited by data-sync-user
Loading

I get the error "Download failed".
I am running uBlock Origin v1.30.6 on Firefox Nightly 201026 17:01 (Build #2015771979). The problem also occurs on the Beta version of Firefox. The Stable released version works OK with the same version of uBlock Origin so bug in Firefox.

Steps to reproduce

Open the uBlock Origin addon and export either a rules file or click backup to file from the Settings. I have Open Links in Apps turned off.

Expected behavior

The rules or settings are downloaded.

Actual behavior

Download fails.

Device information

I have tested on a Samsung Galaxy S20 FE 5G, a Samsung Galaxy A11, a Samsung Galaxy S10e, and a Samsung Galaxy Tab S5e. All are running Android 10. The problem occurs on all of them.

  • Fenix version: ?
    201026 17:01 (Build #2015771979).

┆Issue is synchronized with this Jira Task
@Dan884 Dan884 added the 🐞 bug Crashes, Something isn't working, .. label Oct 28, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 28, 2020
@Dan884 Dan884 mentioned this issue Oct 28, 2020
Closed
@Amejia481
Copy link
Contributor

When we moved to the new GeckoView api we lose some of the functionality for data urls that the previous API provided, it looks like the new api support data urls but we have to do some adjustments for it, as when we use it doesn't provide the same metada as a normal HTTP request, the download is failing here

@Amejia481 Amejia481 mentioned this issue Oct 28, 2020
Closed
@Amejia481
Copy link
Contributor

We put a patch for it on mozilla-mobile/android-components#8829, the issue should be fixed in nightly as soon Fenix updates to new ac version that includes the fix.

@Dan884
Copy link
Author

Dan884 commented Oct 31, 2020

I can confirm that the fix worked. Thanks for all your work.

@Amejia481 Amejia481 added the eng:qa:needed QA Needed label Oct 31, 2020
@Dan884
Copy link
Author

Dan884 commented Oct 31, 2020

I can confirm that the fix worked in Nightly. Thanks for all your work.

Do you know when this Nightly will make it into the Beta release? It is currently broken there as well.

@ebalazs-sv
Copy link

Verified as fixed on Nightly 201102 05:00 (Build #2015773225) GV 84 from 11/2 with Motorola Moto G6 (Android 8).
I will remove the qa:needed label and close this issue.

@ebalazs-sv ebalazs-sv added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Nov 2, 2020
@Amejia481
Copy link
Contributor

I can confirm that the fix worked in Nightly. Thanks for all your work.

Do you know when this Nightly will make it into the Beta release? It is currently broken there as well.

You can see the release schedule here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Download Feature:WebExtensions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Amejia481 @ebalazs-sv @Dan884