Close #8823 allow data urls to be downloaded using the new gv download api #8829

Amejia481 · 2020-10-28T19:11:14Z

When we moved to the new GeckoView api, we gained the functionality of downloading data URLs that the previous API didn't provided and we handled ourself, but we have to do some adjustments for it, as it doesn't have the same info as a HTTP request, like response.status or headers, for data URIs we have to do not do checks for these fields

Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
Tests: This PR includes thorough tests or an explanation of why it does not
Changelog: This PR includes a changelog entry or does not need one
Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

...cko-beta/src/main/java/mozilla/components/browser/engine/gecko/fetch/GeckoViewFetchClient.kt

using the new gv downloaded api

csadilek

👍

Amejia481 added the 🕵️‍♀️ needs review PRs that need to be reviewed label Oct 28, 2020

Amejia481 requested a review from csadilek October 28, 2020 19:11

Amejia481 assigned csadilek Oct 28, 2020

Amejia481 mentioned this pull request Oct 28, 2020

Download of Rules or Settings from uBlock Origin fails mozilla-mobile/fenix#16228

Closed

Amejia481 force-pushed the issue_8823 branch from 3fd8151 to ca3cd2b Compare October 28, 2020 21:29

Amejia481 requested a review from pocmo as a code owner October 28, 2020 21:29

csadilek reviewed Oct 28, 2020

View reviewed changes

...cko-beta/src/main/java/mozilla/components/browser/engine/gecko/fetch/GeckoViewFetchClient.kt Show resolved Hide resolved

Close mozilla-mobile#8823 allow data urls to be download

0b2dda9

using the new gv downloaded api

Amejia481 force-pushed the issue_8823 branch from ca3cd2b to 0b2dda9 Compare October 28, 2020 22:18

Amejia481 removed the request for review from pocmo October 28, 2020 22:56

csadilek approved these changes Oct 29, 2020

View reviewed changes

Amejia481 added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Oct 29, 2020

Merge branch 'master' into issue_8823

996939c

mergify bot merged commit 5ea24d7 into mozilla-mobile:master Oct 29, 2020

Provide feedback