Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fix breaking APIs in TabsAdapter and ViewHolder #11510

Conversation

jonalmeida
Copy link
Contributor

@jonalmeida jonalmeida commented Jun 12, 2020

Requires breaking API changes from mozilla-mobile/android-components#7356 in the next AC upgrade to land.

@jonalmeida jonalmeida force-pushed the fix-breaking-api-tabs-adapter-oh-yeeee branch from 3cf4940 to 648a087 Compare June 13, 2020 17:39
@jonalmeida jonalmeida force-pushed the fix-breaking-api-tabs-adapter-oh-yeeee branch from 648a087 to 735089c Compare June 13, 2020 18:11
@codecov-commenter
Copy link

Codecov Report

Merging #11510 into master will decrease coverage by 0.00%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11510      +/-   ##
============================================
- Coverage     21.55%   21.55%   -0.01%     
  Complexity      700      700              
============================================
  Files           373      373              
  Lines         15074    15066       -8     
  Branches       2039     2036       -3     
============================================
- Hits           3249     3247       -2     
+ Misses        11537    11533       -4     
+ Partials        288      286       -2     
Impacted Files Coverage Δ Complexity Δ
...pp/src/main/java/org/mozilla/fenix/HomeActivity.kt 8.82% <0.00%> (+0.15%) 10.00 <0.00> (ø)
...java/org/mozilla/fenix/tabtray/FenixTabsAdapter.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ava/org/mozilla/fenix/tabtray/TabTrayViewHolder.kt 38.09% <100.00%> (+0.41%) 7.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704fc6f...735089c. Read the comment docs.

@jonalmeida jonalmeida merged commit 7e61165 into mozilla-mobile:master Jun 13, 2020
@jonalmeida jonalmeida deleted the fix-breaking-api-tabs-adapter-oh-yeeee branch June 13, 2020 20:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants