Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #24969 - Display address autofill prompt #25227

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

Alexandru2909
Copy link
Contributor

Display address autofill prompt.
Depends on 12061.

Because there have been some issues with the onAddressSelect callback being triggered when the user interacts with an address form, please consider dispatching the PromptRequest from the Fenix code for testing.

Collapsed screenshot:
Screenshot_20220513_144850

Expanded screenshot:
Screenshot_20220513_142727

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@Alexandru2909 Alexandru2909 requested review from a team as code owners May 13, 2022 11:49
@Alexandru2909 Alexandru2909 added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label May 13, 2022
@Alexandru2909 Alexandru2909 marked this pull request as draft May 13, 2022 12:12
@Alexandru2909 Alexandru2909 marked this pull request as ready for review May 31, 2022 17:47
@Alexandru2909
Copy link
Contributor Author

This is ready for review since mozilla-mobile/android-components#12142 was merged.

@Alexandru2909 Alexandru2909 removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Jun 2, 2022
@Alexandru2909 Alexandru2909 added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Jun 15, 2022
@mergify mergify bot merged commit 3b4e11b into mozilla-mobile:main Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants