Fix workflow to update server names #9518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed that it's working (manually triggered from branch, created #9519) |
flodolo
commented
May 9, 2024
| @@ -21,6 +21,11 @@ jobs: | |||
| uses: actions/checkout@v4 | |||
| with: | |||
| submodules: "true" | |||
| - uses: actions/setup-python@v5 | |||
There was a problem hiding this comment.
Using v5 directly, as there's another PR trying to update all the workflows #9520
brizental
approved these changes
May 9, 2024
|
I guess we should drop 96bbdec before merge. |
Yes, I can manually trigger the workflow after this is merged. I originally didn't realize the PR was opened against the branch. |
flodolo
force-pushed
the
fix_server_names_workflow
branch
from
6538194 to
d62a33c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflow is currently broken (missing deps), and has the same name of another workflow.