fix: don't check storage for new uaid's

Closes #1017

autopush/tests/test_webpush_server.py

@@ -234,6 +234,7 @@ def test_nonexisting_uaid(self):
         result = p.process(hello)  # type: HelloResponse
         ok_(isinstance(result, HelloResponse))
         ok_(hello.uaid != result.uaid)
+        eq_(result.check_storage, False)
 
     def test_existing_uaid(self):
         p = self._makeFUT()
@@ -244,6 +245,7 @@ def test_existing_uaid(self):
         result = p.process(hello)  # type: HelloResponse
         ok_(isinstance(result, HelloResponse))
         eq_(hello.uaid.hex, result.uaid)
+        eq_(result.check_storage, True)
 
     def test_existing_newer_uaid(self):
         p = self._makeFUT()

autopush/webpush_server.py

@@ -157,6 +157,7 @@ class OutputCommand(object):
 class HelloResponse(OutputCommand):
     uaid = attrib()  # type: Optional[str]
     message_month = attrib()  # type: str
+    check_storage = attrib()  # type: bool
     reset_uaid = attrib()  # type: bool
     rotate_message_table = attrib(default=False)  # type: bool
 
@@ -337,6 +338,7 @@ def process(self, hello):
         # type: (Hello) -> HelloResponse
         user_item = None
         flags = dict(
+            check_storage=False,
             message_month=self.db.current_msg_month,
             reset_uaid=False
         )
@@ -359,8 +361,9 @@ def lookup_user(self, hello):
         # type: (Hello) -> (Optional[JSONDict], JSONDict)
         flags = dict(
             message_month=None,
-            rotate_message_table=False,
+            check_storage=False,
             reset_uaid=False,
+            rotate_message_table=False,
         )
         uaid = hello.uaid.hex
         try:
@@ -380,6 +383,9 @@ def lookup_user(self, hello):
             self.db.router.drop_user(uaid)
             return None, flags
 
+        # If we got here, its a valid user that needs storage checked
+        flags["check_storage"] = True
+
         # Determine if message table rotation is needed
         flags["message_month"] = record["current_month"]
         if record["current_month"] != self.db.current_msg_month:

autopush_rs/src/call.rs

@@ -187,6 +187,7 @@ struct PythonError {
 pub struct HelloResponse {
     pub uaid: Option<Uuid>,
     pub message_month: String,
+    pub check_storage: bool,
     pub reset_uaid: bool,
     pub rotate_message_table: bool,
 }