bug: Return correct status code/errno for ADM auth failures

Closes: #1345
mozilla-services · Aug 13, 2019 · e023ad6 · e023ad6
1 parent e404674
commit e023ad6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/autopush/router/adm.py b/autopush/router/adm.py
@@ -202,8 +202,8 @@ def _route(self, notification, uaid_data):
                                        self._base_tags,
                                        reason="auth failure"
                                    ))
-            raise RouterException("Server error", status_code=500,
-                                  errno=902,
+            raise RouterException("Server error", status_code=502,
+                                  errno=901,
                                   log_exception=False)
         except Exception as e:
             self.log.error("Unhandled exception in ADM Routing: %s" % e)

diff --git a/autopush/tests/test_integration.py b/autopush/tests/test_integration.py
@@ -2154,7 +2154,7 @@ def test_bad_token_refresh(self):
             }),
             body=data
         )
-        assert response.code == 500
+        assert response.code == 502
         self.flushLoggedErrors()
 
     @inlineCallbacks
@@ -2192,9 +2192,9 @@ def test_bad_sends(self):
             }),
             body="BunchOfStuff"
         )
-        assert response.code == 500
+        assert response.code == 502
         rbody = json.loads(body)
-        assert rbody["errno"] == 902
+        assert rbody["errno"] == 901
         self.flushLoggedErrors()
 
         # fake a valid ADM key