Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Refactor out one of the waiting states #1165

Closed
bbangert opened this issue Mar 26, 2018 · 0 comments
Closed

Refactor out one of the waiting states #1165

bbangert opened this issue Mar 26, 2018 · 0 comments
Assignees
@bbangert
Labels
enhancement p1
Milestone
2018Q1-1.1 Rust c...

Comments

@bbangert
Copy link
Member

The rust connection node currently has two waiting states with almost identical source code. They should be combined into a single command waiting state, that does the ack check up front, and appropriately ignores ack's when they shouldn't be waiting. This would remove the duplicate code between the Await and WaitingForAcks states.
@bbangert bbangert added the ready label Mar 26, 2018
@bbangert bbangert self-assigned this Mar 26, 2018
bbangert added a commit that referenced this issue Mar 31, 2018
@bbangert
feat: refactor client to remove duplicate logic
4782084 
WaitingForAck's was essentially identical to Await, except it allowed
for Ack's to come in. Combining these reduces duplication and errors
that may occur as a result while simplifying command handling.

Closes #1165
@bbangert bbangert mentioned this issue Mar 31, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbangert bbangert

Labels
enhancement p1
Projects
None yet
Milestone
2018Q1-1.1 Rust connection nodes work...
Development

No branches or pull requests
2 participants
@jrconlin @bbangert