Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

kill the slog_scope logger guard #1184

Closed
pjenvey opened this issue Apr 20, 2018 · 0 comments
Closed

kill the slog_scope logger guard #1184

pjenvey opened this issue Apr 20, 2018 · 0 comments
Assignees
Labels

Comments

@pjenvey
Copy link
Member

pjenvey commented Apr 20, 2018

When dropped, slog_scope's logger guard resets the global logger to 'NoGlobalLoggerSet' which panics on log messages. We introduced reset_logging in b2132f to avoid potential panics during tests but they can still occur (especially when compiled in debug mode which can enable more verbose logging in our support libs).

I think I'm seeing drop of this guard happen after our reset_logging is called. I'm not sure why, maybe because of our tie ins on the Python side, see the cffi ffi.gc calls.

I've also seen a random lazy_static! block initialize something in a thread that triggers panics. Long story short: they're difficult to avoid, so let's disable the guard for now and report this issue to slog_scope as bad behavior.

@pjenvey pjenvey added the bug label Apr 20, 2018
@pjenvey pjenvey self-assigned this Apr 20, 2018
pjenvey added a commit that referenced this issue Apr 20, 2018
pjenvey added a commit that referenced this issue Apr 23, 2018
pjenvey added a commit that referenced this issue Apr 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants