Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Don't report non-exceptions as failure() #1388

Closed
jrconlin opened this issue May 7, 2020 · 0 comments · Fixed by #1389
Closed

Don't report non-exceptions as failure() #1388

jrconlin opened this issue May 7, 2020 · 0 comments · Fixed by #1389
Assignees
@jrconlin

Comments

@jrconlin
Copy link
Member

jrconlin commented May 7, 2020

In base, write_error reports non exception errors as self.log.failure which will raise a "NoCurrentExceptionError".

This should probably just return a self.log.error()
@jrconlin jrconlin self-assigned this May 7, 2020
jrconlin added a commit that referenced this issue May 7, 2020
@jrconlin
bug: only use failure() on exceptions in write_error
3e7c2b2 
Closes #1388
@jrconlin jrconlin mentioned this issue May 7, 2020
Merged
pjenvey pushed a commit that referenced this issue May 7, 2020
@jrconlin
Bug/1388 (#1389)
d11f5ac 
* bug: only use `failure()` on exceptions in write_error

Closes #1388
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrconlin jrconlin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug/1388 mozilla-services/autopush
1 participant
@jrconlin