Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Add SHA dependency checks #454

Closed
bbangert opened this issue Apr 26, 2016 · 8 comments
Closed

Add SHA dependency checks #454

bbangert opened this issue Apr 26, 2016 · 8 comments

Comments

@bbangert
Copy link
Member

bbangert commented Apr 26, 2016

pip now lets us add SHA hashes to dependencies, we should use these:

@bbangert bbangert added this to the PUSHSVC-0: quality milestone May 9, 2016
@bbangert bbangert added the ready label May 9, 2016
@pjenvey
Copy link
Member

pjenvey commented Oct 6, 2016

These can be potentially bothersome but should be worth it. You usually include a hash of the .tar.gz and a platform's .whl, but can include as many as needed

The hashin utility can produce these for us. But piptools' pip-compile may get support for what hashin does soon:

jazzband/pip-tools#303

w/ pip-compile you can keep the most bare minimum requirements in a '.in' file (a lot like what you'd have in setuptools requires).

It then version pins everything from it including all the sub dependencies. It mentions in the final requirements file where those sub dependencies are from.

e.g.:
six==1.10.0 # via autobahn, cryptography, pyopenssl, python-dateutil, python-jose, txaio

Then it has a --upgrade feature, which is similar to what pyup provides

@oberstet
Copy link

You could steel from this .. using hashin

@pjenvey
Copy link
Member

pjenvey commented Jan 18, 2017

FYI @oberstet pip-tools actually has support for handling these now (that jazzband/pip-tools#303 should be closed out). When be switch to it we'll be gaining the .in file format/upgrading and now the hash support too

@pjenvey pjenvey added p2 p3 and removed p2 labels Apr 12, 2017
pjenvey added a commit that referenced this issue Jul 5, 2017
kill the unneeded future dep and move pycrypto into tests only

Issue: #454
@pjenvey
Copy link
Member

pjenvey commented Jul 5, 2017

We can't enable hash checks while still using editable url specs (txstatsd and temporarily crytography).

I've pinged txstatsd's lauchpad for a new release.. but will probably have to get in touch with them via some other means

@pjenvey pjenvey added blocked and removed ready labels Jul 5, 2017
pjenvey added a commit that referenced this issue Jul 13, 2017
also upgrade deps via pip-tools: and kill the unneeded future dep and
move pycrypto into tests only

also title case the Issue/Closes footer in CONTRIBUTING

Closes: #949
Issue: #454
pjenvey added a commit that referenced this issue Jul 13, 2017
also upgrade deps via pip-tools: and kill the unneeded future dep and
move pycrypto into tests only

also title case the Issue/Closes footer in CONTRIBUTING

Closes: #949
Issue: #454
@bbangert
Copy link
Member Author

Once we go to Rust for connection node, we can drop txstatsd and should be able to do this.

@pjenvey
Copy link
Member

pjenvey commented Apr 24, 2018

endpoint still needs it, no?

@bbangert
Copy link
Member Author

Aw right, we're still on twisted for the endpoint, doh.

@bbangert
Copy link
Member Author

Won't be addressing this as we're moving entirely to Rust soonish.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants