Check and remove assert calls #674

jrconlin · 2016-09-27T16:21:01Z

Assert calls can disappear in optimized code, as well as not work quite as expected in many cases
(e.g. assert (foo == bar, "error") === assert (False, "error") === assert True )

We should scrub out assert and unit tests that call .assert*.

The text was updated successfully, but these errors were encountered:

issue #674

closes #674

issue #674

jrconlin added this to the PUSHSVC-0: quality milestone Sep 27, 2016

bbangert added p2 ready labels Sep 29, 2016

pjenvey self-assigned this Oct 4, 2016

pjenvey added a commit that referenced this issue Oct 4, 2016

fix: assert -> ok_

9b83d9c

issue #674

pjenvey added a commit that referenced this issue Oct 4, 2016

fix: adapt asserts to ok/eq_

e9fd8a1

issue #674

pjenvey added a commit that referenced this issue Oct 4, 2016

fix: assertTrue -> ok_

db4e6dc

issue #674

pjenvey added a commit that referenced this issue Oct 4, 2016

fix: assertTrue -> eq_

c01eb4d

issue #674

pjenvey added a commit that referenced this issue Oct 4, 2016

fix: assertRaises -> assert_raises

3e8e19d

closes #674

pjenvey added in progress and removed ready labels Oct 4, 2016

pjenvey mentioned this issue Oct 4, 2016

issue 674: kill asserts #681

Merged

pjenvey added a commit that referenced this issue Oct 4, 2016

fix: assertRaises -> assert_raises

e417325

issue #674

pjenvey closed this as completed in #681 Oct 4, 2016

pjenvey removed the in progress label Oct 4, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check and remove assert calls #674

Check and remove assert calls #674

jrconlin commented Sep 27, 2016 •

edited by bbangert

Loading

Check and remove assert calls #674

Check and remove assert calls #674

Comments

jrconlin commented Sep 27, 2016 • edited by bbangert Loading

jrconlin commented Sep 27, 2016 •

edited by bbangert

Loading