Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

fix table rotation (update_rotating_tables/get_rotating_message_table) #722

Closed
pjenvey opened this issue Nov 1, 2016 · 0 comments
Closed

fix table rotation (update_rotating_tables/get_rotating_message_table) #722

pjenvey opened this issue Nov 1, 2016 · 0 comments
Assignees
@bbangert
Labels
bug p1

Comments

@pjenvey
Copy link
Member

pjenvey commented Nov 1, 2016 •
edited by bbangert
Loading

The lambda function that creates the new month's message table failed this month. That caused update_rotating_tables task to fail.

get_rotating_message_table takes a delta/date but neglected to pass along the date to create_rotating_message_table.

Additionally, update_rotating_tables is calling get_rotating_message_table in the event loop
@bbangert bbangert added the ready label Nov 7, 2016
@pjenvey pjenvey changed the title fix table rotation fix table rotation (update_rotating_tables/get_rotating_message_table) Nov 7, 2016
@bbangert bbangert changed the title fix table rotation (update_rotating_tables/get_rotating_message_table) fix table rotation Nov 8, 2016
@bbangert bbangert added in progress and removed ready labels Nov 8, 2016
@bbangert bbangert self-assigned this Nov 8, 2016
bbangert added a commit that referenced this issue Nov 8, 2016
@bbangert
feat: retain date when checking message tables
4c1a377 
Ensures the date argument is passed along with the table name
when creating the rotating message table during the
get_rotating_message_table call.

Closes #722
@bbangert bbangert mentioned this issue Nov 8, 2016
Merged
@pjenvey pjenvey changed the title fix table rotation fix table rotation (update_rotating_tables/get_rotating_message_table) Nov 8, 2016
bbangert added a commit that referenced this issue Nov 8, 2016
@bbangert
feat: retain date when checking message tables
800ded5 
Ensures the date argument is passed along with the table name
when creating the rotating message table during the
get_rotating_message_table call.

Closes #722
bbangert added a commit that referenced this issue Nov 8, 2016
@bbangert
feat: retain date when checking message tables
c7aae0c 
Ensures the date argument is passed along with the table name
when creating the rotating message table during the
get_rotating_message_table call.

Closes #722
bbangert added a commit that referenced this issue Nov 8, 2016
@bbangert
feat: retain date when checking message tables (#727)
04756c4 
Ensures the date argument is passed along with the table name
when creating the rotating message table during the
get_rotating_message_table call.

Closes #722
This was referenced Nov 16, 2016
Open
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbangert bbangert

Labels
bug p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjenvey @bbangert