Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

hasher called w/ UUID objects #984

Closed
pjenvey opened this issue Jul 26, 2017 · 0 comments · Fixed by #986
Closed

hasher called w/ UUID objects #984

pjenvey opened this issue Jul 26, 2017 · 0 comments · Fixed by #986
Assignees
@pjenvey
Labels
bug

Comments

@pjenvey
Copy link
Member

pjenvey commented Jul 26, 2017

Noticed by mypy:

autopush/web/registration.py:320: error: Argument 1 to "hasher" has incompatible type "UUID"; expected "str"

(one in _write_endpoint and _delete_channel)

This can cause hasher to blow up but only with a key_hash configured (which isn't configured on prod)
@pjenvey pjenvey added the bug label Jul 26, 2017
@pjenvey pjenvey self-assigned this Jul 26, 2017
pjenvey added a commit that referenced this issue Jul 27, 2017
@pjenvey
fix: hasher doesn't take UUIDs
69b91de 
and fix ChannelRegistrationHandler now taking a UUID chid after the
last refactor and some type sigs

Closes #984
@pjenvey pjenvey mentioned this issue Jul 27, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjenvey pjenvey

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: hasher doesn't take UUIDs mozilla-services/autopush
2 participants
@pjenvey @bbangert