This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
feat: add Strict-Transport-Security header #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1035 +/- ##
==========================================
+ Coverage 99.76% 99.76% +<.01%
==========================================
Files 55 55
Lines 8799 8811 +12
==========================================
+ Hits 8778 8790 +12
Misses 21 21
Continue to review full report at Codecov.
|
pjenvey
reviewed
Oct 4, 2017
| if self.conf.sts_max_age: | ||
| self.set_header("Strict-Transport-Security", | ||
| ";".join([ | ||
| "max-age={}".format(self.conf.sts_max_age), |
There was a problem hiding this comment.
eh could have just done it all in the .format string but no biggie
There was a problem hiding this comment.
Thought about it. Decided on this partly because there's a few other potential options and the wrapping would have gotten ugly.
pjenvey
approved these changes
Oct 4, 2017
bbangert
approved these changes
Oct 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1031