fix: drop users with no router_type recorded #1065
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1065 +/- ##
==========================================
- Coverage 99.75% 99.73% -0.03%
==========================================
Files 56 56
Lines 8888 8904 +16
==========================================
+ Hits 8866 8880 +14
- Misses 22 24 +2
Continue to review full report at Codecov.
|
| @@ -54,6 +54,8 @@ | |||
| # Base64 URL validation | |||
| VALID_BASE64_URL = re.compile(r'^[0-9A-Za-z\-_]+=*$') | |||
|
|
|||
| VALID_ROUTER_TYPES = ["simplepush", "webpush", "gcm", "fcm", "apns"] | |||
There was a problem hiding this comment.
Really thought I had something like this before. There's a similar list in autopush.registration.conditional_token_check Wonder if it might make sense to have this list somewhere common and use it in both locations?
There was a problem hiding this comment.
Yea, or heck, maybe a constants.py for the shared universal constants we end up using all over.
There was a problem hiding this comment.
absolutely 👍 to a constants.py. I've got one for boto I put in __init__.py, but happy to move it in favor of just keeping version there.
There was a problem hiding this comment.
Will open a separate PR to refactor some of the constants together.
Closes #1058