This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
bug: Normalize padding handling for restricted subscriptions #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100%@@ master #467 diff @@
====================================
Files 31 31
Lines 7498 7501 +3
Methods 0 0
Messages 0 0
Branches 0 0
====================================
+ Hits 7498 7501 +3
Misses 0 0
Partials 0 0
|
|
This changes generation of new endpoints, is there a test already that has old endpoints with the padding so we can be 100% sure existing endpoints work? |
|
We should use BaseEmoji instead of Base64. @jrconlin suggests using 😭 for padding. |
| dummy_uaid, | ||
| dummy_chid, | ||
| dummy_key) | ||
| (_, token) = ep.split("/")[-2:] |
There was a problem hiding this comment.
Parens on left side not needed.
|
r+, minor python nits |
Since fernet passes it's content through base64 handling, it's just as picky about padding as other base64 instances. For now, strip padding from outbound endpoints and reapply it (if needed) to inbound endpoints. Closes #466
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since fernet passes it's content through base64 handling, it's just as
picky about padding as other base64 instances. For now, strip padding
from outbound endpoints and reapply it (if needed) to inbound endpoints.
Closes #466
@bbangert r?