This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
fix: remove use of buggy moto from websocket/db tests #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moto's testing harness is a bit buggy, it was returning errors in a semi-random manner during test-runs and failing to do validation checks that DynamoDB performs. As such we now spin up the Java DynamoDB local server for these test files to ensure consistent responses. Closes #531
|
r+ |
Current coverage is 99.95%@@ master #533 diff @@
========================================
Files 40 40
Lines 8360 8352 -8
Methods 0 0
Messages 0 0
Branches 0 0
========================================
- Hits 8360 8348 -12
- Misses 0 4 +4
Partials 0 0
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moto's testing harness is a bit buggy, it was returning errors in
a semi-random manner during test-runs and failing to do
validation checks that DynamoDB performs. As such we now
spin up the Java DynamoDB local server for these test files to
ensure consistent responses.
Closes #531
@jrconlin r?