This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
bug: label arguments for router.register to prevent misassignment #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,7 +44,7 @@ def __init__(self, ap_settings, router_conf): | |||
| self._connect() | |||
| self.log.debug("Starting APNS router...") | |||
|
|
|||
| def register(self, uaid, router_data, *args, **kwargs): | |||
| def register(self, uaid, router_data={}, *args, **kwargs): | |||
There was a problem hiding this comment.
we really don't want the mutable default (router_data={}) here. router_data seems to be always be required, so it should continue being a positional argument to enforce that
Serial argument assignment can lead to misassignment of arguments in some cases. It's best to be explicit where one can be. closes #642
jrconlin
changed the title
Current coverage is 100% (diff: 100%)@@ master #648 diff @@
====================================
Files 45 45
Lines 9171 9171
Methods 0 0
Messages 0 0
Branches 0 0
====================================
Hits 9171 9171
Misses 0 0
Partials 0 0
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serial argument assignment can lead to misassignment of arguments in
some cases. It's best to be explicit where one can be.
closes #642