Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

chore: remove the wsaccel dependency on pypy #683

Merged
merged 2 commits into from
Oct 7, 2016
Merged

chore: remove the wsaccel dependency on pypy #683

merged 2 commits into from
Oct 7, 2016

Conversation

pjenvey
Copy link
Member

@pjenvey pjenvey commented Oct 6, 2016

keep it in test-requirements (implying cpython for now)

issue #560

I might shuffle the requirements around a bit soon so keeping this simple for now (i.e. no pypy-test-requirements.txt yet)

keep it in test-requirements (implying cpython for now)

issue #560
@codecov-io
Copy link

codecov-io commented Oct 6, 2016

Current coverage is 100% (diff: 100%)

Merging #683 into master will not change coverage

@@           master   #683   diff @@
====================================
  Files          48     48          
  Lines        9741   9741          
  Methods         0      0          
  Messages        0      0          
  Branches        0      0          
====================================
  Hits         9741   9741          
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update cf74d40...ede0d81

Copy link
Member

@jrconlin jrconlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+, although wonder if we should move requirements.txt to python-requirements.txt. Might be able to remove the conditional from the Makefile.

@bbangert bbangert merged commit aa047f3 into master Oct 7, 2016
@bbangert bbangert deleted the fix/560 branch October 7, 2016 01:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants