This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
fix: kill websocket.Notification #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrconlin
reviewed
Oct 13, 2016
| @@ -51,6 +51,20 @@ | |||
| "content-encoding": "aesgcm", | |||
| "TTL": "60", | |||
| } | |||
| dummy_chid = str(uuid.uuid4()) | |||
| dummy_uaid = str(uuid.uuid4()) | |||
There was a problem hiding this comment.
dummy_uaid is only used once. Does it need to be a string or can it stay a UUID?
There was a problem hiding this comment.
..was thinking similarly but our other tests' dummy uuids are strs. but let's move that way anyway
Current coverage is 100% (diff: 100%)@@ master #707 diff @@
====================================
Files 48 48
Lines 9764 9767 +3
Methods 0 0
Messages 0 0
Branches 0 0
====================================
+ Hits 9764 9767 +3
Misses 0 0
Partials 0 0
|
bbangert
approved these changes
Oct 13, 2016
this was now dead code only misused by tests closes #706
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was now dead code only misused by tests
closes #706