Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

feat: switch proxy_protocol -> proxy_protocol_port #789

Merged
merged 1 commit into from
Jan 27, 2017
Merged

Conversation

pjenvey
Copy link
Member

@pjenvey pjenvey commented Jan 25, 2017

now toggles exposing a separate port w/ proxy protocol handling

fixes #788

@codecov-io
Copy link

codecov-io commented Jan 25, 2017

Current coverage is 100% (diff: 100%)

Merging #789 into master will not change coverage

@@           master   #789   diff @@
====================================
  Files          46     46          
  Lines        9277   9289    +12   
  Methods         0      0          
  Messages        0      0          
  Branches        0      0          
====================================
+ Hits         9277   9289    +12   
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update f8c819e...42cb27b

Copy link
Member

@bbangert bbangert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Copy link
Member

@jrconlin jrconlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm tempted to suggest that proxy_protocol be added to the obsolete list, otherwise folks with existing configs could break if they were using it. However, I'm also willing to say that number should be very small.

now toggles exposing a separate port w/ proxy protocol handling

fixes #788
@bbangert bbangert merged commit 81e3af4 into master Jan 27, 2017
@bbangert bbangert deleted the feat/788 branch January 27, 2017 16:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch proxy_protocol option -> proxy_protocol_port
4 participants