-
Notifications
You must be signed in to change notification settings - Fork 30
feat: accept aes128gcm content encoding #932
Conversation
Codecov Report
@@ Coverage Diff @@
## master #932 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 57 57
Lines 9419 9464 +45
=====================================
+ Hits 9419 9464 +45
Continue to review full report at Codecov.
|
autopush/web/webpush.py
Outdated
content_encoding = fields.String( | ||
required=True, | ||
load_from="content-encoding", | ||
validate=OneOf(["aes128gcm"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: think I've mentioned this before but we always end up w/ OneOf([onething]), should just be Equals(onething)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point. I'll change the other ones that do the same thing.
If the commit doesn't use a capital c for 'closes', then clog doesn't see it. Which is unfortunately kind of sad, since our contributing doc makes it sound like all lowercase 'closes' is fine. This is why some of our changelog is missing Issue linkage for what it closed. |
closes #930
NOTE: pjenvey: If this conflicts with your refactor, this has lower priority.