Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

feat: accept aes128gcm content encoding #932

Merged
merged 1 commit into from
Jun 22, 2017
Merged

feat: accept aes128gcm content encoding #932

merged 1 commit into from
Jun 22, 2017

Conversation

jrconlin
Copy link
Member

closes #930

NOTE: pjenvey: If this conflicts with your refactor, this has lower priority.

@codecov-io
Copy link

codecov-io commented Jun 22, 2017

Codecov Report

Merging #932 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #932   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          57     57           
  Lines        9419   9464   +45     
=====================================
+ Hits         9419   9464   +45
Impacted Files Coverage Δ
autopush/router/gcm.py 100% <100%> (ø) ⬆️
autopush/tests/test_integration.py 100% <100%> (ø) ⬆️
autopush/router/fcm.py 100% <100%> (ø) ⬆️
autopush/web/webpush.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14f3d87...00947d1. Read the comment docs.

content_encoding = fields.String(
required=True,
load_from="content-encoding",
validate=OneOf(["aes128gcm"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: think I've mentioned this before but we always end up w/ OneOf([onething]), should just be Equals(onething)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point. I'll change the other ones that do the same thing.

pjenvey
pjenvey previously approved these changes Jun 22, 2017
@bbangert
Copy link
Member

If the commit doesn't use a capital c for 'closes', then clog doesn't see it. Which is unfortunately kind of sad, since our contributing doc makes it sound like all lowercase 'closes' is fine. This is why some of our changelog is missing Issue linkage for what it closed.

bbangert
bbangert previously approved these changes Jun 22, 2017
@pjenvey pjenvey merged commit 75a1fa0 into master Jun 22, 2017
@pjenvey pjenvey deleted the bug/930 branch June 22, 2017 23:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept messages with Content-Encoding: aes128gcm
4 participants