Skip to content
This repository has been archived by the owner on Mar 28, 2019. It is now read-only.

Expose the authenticated_userid in an endpoint #319

Merged
merged 2 commits into from
Jul 15, 2015
Merged

Conversation

Natim
Copy link
Contributor

@Natim Natim commented Jul 15, 2015

Clients need to know what's their userid is, in order to set and manage permission.

We should expose that in either an extra endpoint or the root one.
We may use the same endpoint as #318 in case we decide to create one.

@Natim
Copy link
Contributor Author

Natim commented Jun 16, 2015

Also now that the creator have got an automatic write access it is a bit less urgent.

@almet almet added this to the 2.3 milestone Jul 7, 2015
@leplatrem leplatrem modified the milestone: 2.3 Jul 13, 2015
@Natim
Copy link
Contributor Author

Natim commented Jul 15, 2015

I propose to add a userid field in the home page so that we can fetch the userid when fetching the settings.

Natim pushed a commit that referenced this pull request Jul 15, 2015
@Natim Natim self-assigned this Jul 15, 2015
@Natim
Copy link
Contributor Author

Natim commented Jul 15, 2015

r? @n1k0 @leplatrem

@leplatrem
Copy link
Contributor

I remember that @ametaireau did not agree with that, since the hello endpoint does not require authentication...
On my side, I don't have any strong opinion on this, and would r+ (with documentation and changelog updated)

@Natim
Copy link
Contributor Author

Natim commented Jul 15, 2015

Note that with this PR the hello endpoint doesn't require authentication. It is just that if you need a userid you will provide a user Authentication.

@Natim Natim force-pushed the 319-add-prefixed-userid branch from c1b1493 to 57725d3 Compare July 15, 2015 13:08
@Natim
Copy link
Contributor Author

Natim commented Jul 15, 2015

I will merge for now and ask @ametaireau when he comes back and we can change the behaviour before the next release if necessary.

The reason why I think this is a good and acceptable solution:

  • We can retrieve the userid on the / endpoint as well as the settings (could be done in one request)
  • We don't force people to access the / endpoint with an Authorization header

Natim added a commit that referenced this pull request Jul 15, 2015
Expose the authenticated_userid in an endpoint
@Natim Natim merged commit 20941e5 into master Jul 15, 2015
@Natim Natim removed the to review label Jul 15, 2015
@Natim Natim deleted the 319-add-prefixed-userid branch July 15, 2015 13:37
@n1k0
Copy link
Contributor

n1k0 commented Jul 15, 2015

Lagguy r+

@leplatrem
Copy link
Contributor

I don't understand why we were in a hurry for this...

@Natim
Copy link
Contributor Author

Natim commented Jul 15, 2015

We are not.

Natim pushed a commit that referenced this pull request Jul 15, 2015
…d-userid"

This reverts commit 20941e5, reversing
changes made to 47d9b06.

Conflicts:
	CHANGELOG.rst
glasserc pushed a commit that referenced this pull request May 20, 2016
Add hoodie to the other solutions comparison matrix (fixes #282)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants