Notification system #488
Notification system #488
Conversation
| @@ -678,3 +683,31 @@ def test_next_page_url_relies_on_headers_information(self): | |||
| resp = self.app.get(self.collection_url + '?_limit=1', | |||
| headers=headers) | |||
| self.assertIn('https://server.name:443', resp.headers['Next-Page']) | |||
|
|
|||
|
|
|||
| class EventsTest(BaseWebTest, unittest.TestCase): | |||
There was a problem hiding this comment.
move to separate test_events file :)
| class CollectionChanged(object): | ||
| """Triggered when a collection is changed. | ||
| """ | ||
| def __init__(self, action, collection, request): |
There was a problem hiding this comment.
nit: collection is actually a resource here
| def __init__(self, action, resource, request): | ||
| self.request = request | ||
| service = current_service(request) | ||
| resource_id = service.viewset.get_name(resource.__class__) + '_id' |
There was a problem hiding this comment.
|
Among the remaining tasks, I think of :
Do you agree with that ? Should I create individual issues for each of them ? The original issue for this was #32. But it mentions «pre»/«post» storage hooks. Should we close it with this PR ? And open another issue for hooks where records can be manipulated before/after interactions with storage backend ? |
|
I would like to merge the PR asap before it rots, so I guess the most important stuff (besides the small tasks you added) is to agree on the payload v1. Let's talk about this today and decide |
|
I am adding #501 where I am listing stuff to add in the payload later |
|
FYI the roadmap I had in mind was this : http://cliquet.readthedocs.org/en/latest/rationale.html#roadmap |
|
I can't see any statsd used anywhere in cliquet. I am create a new bug for adding statsd not only in notifications |
|
It looks good to me apart from the failing test. |
Stuff to add before it's ready :