This repository has been archived by the owner on Mar 28, 2019. It is now read-only.
Organize code into a resource module #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1 @@ | |||
| from .base import * | |||
There was a problem hiding this comment.
We should not import * there, either move the base code here or define the __all__ variable.
There was a problem hiding this comment.
yes ok, but what do you think of the overall move ?
leplatrem
force-pushed
the
resource-module
branch
from
b34f7ef to
d8798de
Compare
|
Ready to review ! |
|
It looks good to me. |
leplatrem
force-pushed
the
resource-module
branch
from
11045bc to
4fa4da9
Compare
leplatrem
force-pushed
the
resource-module
branch
from
4fa4da9 to
ff4f576
Compare
leplatrem
added a commit
that referenced
this pull request
Oct 22, 2015
Organize code into a resource module
glasserc
pushed a commit
that referenced
this pull request
May 20, 2016
glasserc
pushed a commit
that referenced
this pull request
May 20, 2016
glasserc
pushed a commit
that referenced
this pull request
May 20, 2016
Do not always start with reload option (fixes #490)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resourcemodule. Since all this is optional to use.CollectiontoModel, since it is what it is :)@Natim @ametaireau thoughts ?