-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MC-1101] feat: Return scheduled corpus items from corpus graph #540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe all my comments are pretty minor. Great work getting here in half a week!
tests/integration/api/v1/curated_recommendations/test_curated_recommendations.py
Outdated
Show resolved
Hide resolved
merino/curated_recommendations/corpus_backends/corpus_api_backend.py
Outdated
Show resolved
Hide resolved
merino/curated_recommendations/corpus_backends/corpus_api_backend.py
Outdated
Show resolved
Hide resolved
tests/integration/api/v1/curated_recommendations/test_curated_recommendations.py
Show resolved
Hide resolved
tests/unit/curated_recommendations/test_curated_recommendations.py
Outdated
Show resolved
Hide resolved
tests/unit/curated_recommendations/test_curated_recommendations.py
Outdated
Show resolved
Hide resolved
tests/integration/api/v1/curated_recommendations/test_curated_recommendations.py
Outdated
Show resolved
Hide resolved
tests/integration/api/v1/curated_recommendations/test_curated_recommendations.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some minor fixes.
I'll create a separate ticket to check whether filtering inmapped topics is a requirement, so we can keep that out-of-scope for this PR.
Hi @katerinachinnappan, just a quick heads up that we have made some tooling changes in #541 that also introduced some conflicts to your PR. A rebase is needed and you can resolve them and then do Re: code review, you don't need my (or other DISCO individual's) r+ for each PR, all of your fellow teammates' review would be sufficient. Feel free to merge once the PR is approved. :) Moving forward, we will sit down together to discuss how to collaborate and build the co-ownership together. |
References
JIRA: https://mozilla-hub.atlassian.net/browse/MC-1101
Description
Make a GRAPHQL request to the curated-corpus-api graph to return scheduled corpus items for the current date.
PR Review Checklist
Put an
x
in the boxes that apply[DISCO-####]
, and has the same title (if applicable)[load test: (abort|warn)]
keywords are applied (if applicable)