Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MC-1101] feat: Return scheduled corpus items from corpus graph #540

Merged
merged 12 commits into from
Jun 25, 2024

Conversation

katerinachinnappan
Copy link
Collaborator

References

JIRA: https://mozilla-hub.atlassian.net/browse/MC-1101

Description

Make a GRAPHQL request to the curated-corpus-api graph to return scheduled corpus items for the current date.

PR Review Checklist

Put an x in the boxes that apply

  • This PR conforms to the Contribution Guidelines
  • The PR title starts with the JIRA issue reference, format [DISCO-####], and has the same title (if applicable)
  • [load test: (abort|warn)] keywords are applied (if applicable)
  • Documentation has been updated (if applicable)
  • Functional and performance test coverage has been expanded and maintained (if applicable)

Copy link
Collaborator

@mmiermans mmiermans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe all my comments are pretty minor. Great work getting here in half a week!

Copy link
Collaborator

@mmiermans mmiermans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor fixes.

I'll create a separate ticket to check whether filtering inmapped topics is a requirement, so we can keep that out-of-scope for this PR.

merino/curated_recommendations/__init__.py Outdated Show resolved Hide resolved
merino/main.py Outdated Show resolved Hide resolved
merino/curated_recommendations/__init__.py Outdated Show resolved Hide resolved
@ncloudioj
Copy link
Contributor

Hi @katerinachinnappan, just a quick heads up that we have made some tooling changes in #541 that also introduced some conflicts to your PR. A rebase is needed and you can resolve them and then do make format and make lint to reformat your PR. Our apologies for that inconvenience.

Re: code review, you don't need my (or other DISCO individual's) r+ for each PR, all of your fellow teammates' review would be sufficient. Feel free to merge once the PR is approved. :)

Moving forward, we will sit down together to discuss how to collaborate and build the co-ownership together.

@ncloudioj ncloudioj removed their request for review June 25, 2024 14:56
@katerinachinnappan katerinachinnappan added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit f7c6a3b Jun 25, 2024
8 checks passed
@katerinachinnappan katerinachinnappan deleted the mc-1101-corpus-api-backend branch June 25, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants