Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DISCO-3192] add new locales for weather expansion #782

Merged
merged 1 commit into from
Feb 5, 2025
Merged

[DISCO-3192] add new locales for weather expansion #782

merged 1 commit into from
Feb 5, 2025

Conversation

tiftran
Copy link
Contributor

@tiftran tiftran commented Feb 5, 2025 •
edited by jira bot
Loading

References

JIRA: DISCO-3192

Description

New locales that need to be added for weather expansion

PR Review Checklist

Put an x in the boxes that apply

  • This PR conforms to the Contribution Guidelines
  • The PR title starts with the JIRA issue reference, format example [DISCO-####], and has the same title (if applicable)
  • [load test: (abort|skip|warn)] keywords are applied to the last commit message (if applicable)
  • Documentation has been updated (if applicable)
  • Functional and performance test coverage has been expanded and maintained (if applicable)

@tiftran tiftran marked this pull request as ready for review February 5, 2025 17:53
@tiftran tiftran requested a review from a team February 5, 2025 18:00
ncloudioj
ncloudioj approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@ncloudioj ncloudioj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we verified that if all those locales are supported by the vendor? If not, do we need to collapse some of those locales? Such as es-* => es.

@tiftran
Copy link
Contributor Author

tiftran commented Feb 5, 2025

Ive double checked that the newly added ones are supported

@tiftran tiftran added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit af5f6c8 Feb 5, 2025
11 checks passed
@tiftran tiftran deleted the new-locales branch February 5, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncloudioj ncloudioj ncloudioj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiftran @ncloudioj