Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild requirements. #88

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Rebuild requirements. #88

merged 1 commit into from
Feb 7, 2025

Conversation

smarnach
Copy link
Contributor

@smarnach smarnach commented Feb 7, 2025

I tried releasing a new version of obs-common, but the GitHub Action failed with this error from twine:

ERROR    InvalidDistribution: Invalid distribution metadata: unrecognized or    
         malformed field 'license-file'

It looks like this has been broken since twine was upgraded a few days ago:

image

The changelog for the twine 6.1.0 release says this:

packaging is used instead of pkginfo for parsing and validating metadata. This aligns metadata validation to the one performed by PyPI. packaging version 24.0 or later is required. Support for metadata version 2.4 requires packaging 24.2 or later. pkginfo is not a dependency anymore. (#1180)

We had packaging 24.1 in our requirements, so I figured rebuilding the requirements to get packaging 24.2 is worth a shot.

@smarnach smarnach requested a review from a team as a code owner February 7, 2025 15:35
Copy link
Contributor

@willkg willkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved those dependabot PRs. I don't remember seeing any errors from the actions anywhere.

When those actions error out, how do we get notified? Am I set up wrong? Did anyone else get notifications? Should we write up an issue about making sure we know when actions fail?

@smarnach
Copy link
Contributor Author

smarnach commented Feb 7, 2025

I didn't get any notifications either. I cut a release because of the bookworm PR, and then clicked on the Actions tab mainly to understand how the Python package upload works.

@smarnach smarnach added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit 27551b6 Feb 7, 2025
3 checks passed
@smarnach smarnach deleted the rebuild-reqs branch February 7, 2025 15:50
@smarnach
Copy link
Contributor Author

smarnach commented Feb 7, 2025

Do we get notifications if CI fails after cutting a release on our other repos? I don't remember seeing any, but maybe that's because that never happens.

@smarnach
Copy link
Contributor Author

smarnach commented Feb 7, 2025

I now realize that I'm not even supposed to manually cut a release. After merging this PR a release got created automatically. Looks like this PR fixed the issue.

@willkg
Copy link
Contributor

willkg commented Feb 7, 2025

I have no idea. It's weird that GitHub actions can fail without notifying anyone. I wonder if there's a setting somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants