address review

mozilla-services · Aug 18, 2022 · 6b5a8f6 · 6b5a8f6
1 parent 98effe6
commit 6b5a8f6
Showing 1 changed file with 16 additions and 0 deletions.
diff --git a/tests/sanic/test_sanic.py b/tests/sanic/test_sanic.py
@@ -96,6 +96,22 @@ def test_client(app):
     return SanicTestClient(app)
 
 
+@pytest.skipif(not sanic.__version__.startswith("20."), "requires sanic 20")
+def test_instantiating_sanic_20(app):
+    dockerflow = Dockerflow()
+    assert "dockerflow.heartbeat" not in app.router.routes_names
+    dockerflow.init_app(app)
+    assert "dockerflow.heartbeat" in app.router.routes_names
+
+
+@pytest.skipif(sanic.__version__.startswith("20."), "requires sanic 21 or later")
+def test_instantiating(app):
+    Dockerflow()
+    assert ("__heartbeat__",) not in app.router.routes_all
+    Dockerflow(app)
+    assert ("__heartbeat__",) in app.router.routes_all
+
+
 def test_instantiating(app):
     Dockerflow()
     if sanic.__version__.startswith("20."):