Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported versions of Python, Django, Flask #69

Merged
merged 18 commits into from
Jul 12, 2022

Conversation

jwhitlock
Copy link
Member

@jwhitlock jwhitlock commented Jul 8, 2022

This PR addresses issue #68, updating versions of Python, Django, Flask, and Sanic to current versions:

  • Python 3.7 to 3.10
  • Django 3.2 and 4.0
  • Flask 0.12, 1.0, 1.1, 2.0, and 2.1
  • Sanic 20, 21, and 22

Checklist:

  • Drop Flask 0.11
  • Drop Django 2.2
  • Drop Django 3.0
  • Add Python 3.10
  • Add Django 3.2
  • Drop Django 3.1
  • Drop Sanic 19
  • Drop Python 3.6
  • Fix Flask 0.12
  • Fix Flask 1.0
  • Add Flask 1.1
  • Add Flask 2.0
  • Add Flask 2.1
  • Add Sanic 21 - Larger change, tracked in issue Support Sanic 21 and later #70
  • Add Sanic 22 - Larger change, tracked in issue Support Sanic 21 and later #70

@jwhitlock jwhitlock marked this pull request as draft July 8, 2022 23:16
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2022

Codecov Report

Merging #69 (1d43c9f) into main (5e30d69) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files          19       19           
  Lines         594      594           
  Branches       93       97    +4     
=======================================
  Hits          581      581           
  Misses          9        9           
  Partials        4        4           
Impacted Files Coverage Δ
src/dockerflow/flask/app.py 94.55% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e30d69...1d43c9f. Read the comment docs.

jwhitlock added 7 commits July 8, 2022 19:08
There is no 0.11.x bugfix branch in pallets/flask, so probably
unsupported.
Extended support ended April 2022
Extended support ended April 2021
Supported by Django 3.2.9 and 4.0.
Django 3.2 LTS is supported until April 2024.
Extended support ended December 2021.
@jwhitlock jwhitlock force-pushed the update-versions-68 branch 3 times, most recently from 0a30203 to 1d43c9f Compare July 9, 2022 02:03
jwhitlock added 2 commits July 8, 2022 21:58
Sanic 19.12 support ended, probably December 2021.
Python 3.6 reached end-of-life on 2021-12-23, according to PEP 494
@jwhitlock jwhitlock force-pushed the update-versions-68 branch from 1d43c9f to 7defc35 Compare July 9, 2022 03:06
@jwhitlock jwhitlock changed the title Update supported versions of Python, Django, Flask, and Sanic Update supported versions of Python, Django, Flask Jul 9, 2022
@jwhitlock jwhitlock force-pushed the update-versions-68 branch from 7defc35 to 605f08a Compare July 9, 2022 03:27
@jwhitlock jwhitlock marked this pull request as ready for review July 9, 2022 03:36
@jwhitlock
Copy link
Member Author

OK, the changes are ready for review, and the build is back to green.

Additional changes to fix linting:

  • Dropped py27 target from black, and re-formatted code
  • Fixed *.pyc removal in MANIFEST.in

Additional cleanup:

  • Removed some leftover py27 variants from tox.ini
  • Removed a skipped Python 2.7 logging test

I added issue #70 to track adding support for newer Sanic versions, which may be tricky.

@jwhitlock jwhitlock requested a review from leplatrem July 11, 2022 18:28
Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sound 💯

@jwhitlock jwhitlock merged commit 141da28 into mozilla-services:main Jul 12, 2022
@jwhitlock jwhitlock deleted the update-versions-68 branch July 12, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants