Merge pull request #2026 from mozilla-services/compat-fix

r?fzzzy Be resilient when receiving bad deviceInfo (as older versions of the …
mozilla-services · Nov 30, 2016 · 0f87fff · 0f87fff
2 parents ad6e409 + 03e2b17
commit 0f87fff
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/server/src/server.js b/server/src/server.js
@@ -487,7 +487,17 @@ app.post("/api/update", function (req, res, next) {
 
 app.post("/api/login", function (req, res) {
   let vars = req.body;
-  let deviceInfo = JSON.parse(vars.deviceInfo);
+  let deviceInfo = {};
+  try {
+    deviceInfo = JSON.parse(vars.deviceInfo);
+  } catch (e) {
+    if (e instanceof SyntaxError) {
+      // JSON isn't valid
+      deviceInfo = {};
+    } else {
+      throw e;
+    }
+  }
   checkLogin(vars.deviceId, vars.secret, deviceInfo.addonVersion).then((ok) => {
     if (ok) {
       let cookies = new Cookies(req, res, {keys: dbschema.getKeygrip()});