Fix #2353, put 3 second limit on error notifications

mozilla-services · Apr 10, 2017 · 3bfd844 · 3bfd844
1 parent 96dfb69
commit 3bfd844
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/addon/webextension/background/senderror.js b/addon/webextension/background/senderror.js
@@ -3,6 +3,9 @@
 window.errorpopup = (function () {
   let exports = {};
 
+  // Do not show an error more than every ERROR_TIME_LIMIT milliseconds:
+  const ERROR_TIME_LIMIT = 3000;
+
   let messages = {
     REQUEST_ERROR: {
       title: browser.i18n.getMessage("requestErrorTitle"),
@@ -41,7 +44,13 @@ window.errorpopup = (function () {
     catcher.unhandled(error);
   });
 
+  let lastErrorTime;
+
   exports.showError = function (error) {
+    if (lastErrorTime && (Date.now() - lastErrorTime) < ERROR_TIME_LIMIT) {
+      return;
+    }
+    lastErrorTime = Date.now();
     let id = makeUuid();
     let popupMessage = error.popupMessage || "generic";
     if (! messages[popupMessage]) {