Fixes #4923 - My Shots favorite icon indicator on signout

mozilla-services · Sep 21, 2018 · 6d25109 · 6d25109
1 parent e632f48
commit 6d25109
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/server/src/pages/shotindex/view.js b/server/src/pages/shotindex/view.js
@@ -1,6 +1,7 @@
 /* globals controller */
 const sendEvent = require("../../browser-send-event.js");
 const reactruntime = require("../../reactruntime");
+const classnames = require("classnames");
 const { MyShotsFooter } = require("./footer");
 const React = require("react");
 const PropTypes = require("prop-types");
@@ -314,12 +315,14 @@ class Card extends React.Component {
     }
 
     let favoriteIndicator = null;
-    if (this.props.hasFxa) {
-      if (!shot.expireTime) {
-        favoriteIndicator = <Localized id="shotIndexFavoriteIcon"><div className="fav-shot" title=""></div></Localized>;
-      } else {
-        favoriteIndicator = <Localized id="shotIndexNonFavoriteIcon"><div className="non-fav-shot" title=""></div></Localized>;
-      }
+    if (!shot.expireTime) {
+      favoriteIndicator = <Localized id="shotIndexFavoriteIcon">
+          <div className={classnames("fav-shot", {"inactive": !this.props.hasFxa})} title=""></div>
+        </Localized>;
+    } else if (this.props.hasFxa) {
+      favoriteIndicator = <Localized id="shotIndexNonFavoriteIcon">
+          <div className="non-fav-shot" title=""></div>
+        </Localized>;
     }
 
     const deleteConfirmationClass = this.state.deletePanelOpen ? "panel-open" : "";

diff --git a/static/css/shot-index.scss b/static/css/shot-index.scss
@@ -206,6 +206,9 @@
 
   .fav-shot {
     background-image: url("../img/icon-heart.svg");
+    &.inactive {
+      opacity: 0.4;
+    }
   }
 
   .non-fav-shot {