-
Notifications
You must be signed in to change notification settings - Fork 128
Update dependencies Greenkeeper found #1703
Comments
At this moment I think it would make sense to just upgrade everything, and then work out any build problems. |
I agree. What problems were you seeing with the react upgrade? |
Browserify wasn't able to find some file, after doing a clean build ( |
That's a different issue that is already in master. For a while now I have had to do |
The clean build wasn't the problem – rather the build problem only showed itself when I did a clean build. |
Yes, the problem was that the node_modules weren't installed before running make all. This problem is in master. I just verified by updating all the modules; I can recreate the problem by running make all without a node_modules, but if I delete node_modules and build, followed by a npm install, and a make all, it works fine with all dependencies updated. |
Maybe we need |
Sure, but that is a different bug that should be filed. It has nothing to do with updating the deps. |
r? ianbicking Fixes #1703 Update all deps to latest.
I think the Makefile uses things that get npm-installed just to setup the basic environment, so in practice npm install just has to be run before make. The scripts ensure this at least. I don't think there's anything else worth fixing there. |
Sounds good! |
I closed its first PR, #1642, because the React upgrades seemed to break the build. But it had many dependencies that could be easily updated.
The text was updated successfully, but these errors were encountered: