Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Remove deviceInfo pref after migrating #2370

Closed
ianb opened this issue Mar 13, 2017 · 0 comments
Closed

Remove deviceInfo pref after migrating #2370

ianb opened this issue Mar 13, 2017 · 0 comments
Assignees
@jaredhirsch
Milestone
General Release 55

Comments

@ianb
Copy link
Contributor

ianb commented Mar 13, 2017 •
edited by pdehaan
Loading

See the FIXME in bootstrap.js. This is a followup to #2371 (64213c0)
@ianb ianb mentioned this issue Mar 13, 2017
Merged
@ianb ianb added this to the Page Shot in 54 milestone Mar 15, 2017
jaredhirsch added a commit that referenced this issue Mar 17, 2017
@jaredhirsch
Fix #2370, unset deviceId pref set by old addon
c020dcc
jaredhirsch pushed a commit that referenced this issue Mar 18, 2017
@ianb @jaredhirsch
Fix #2332, fix #2333: toggle webextension on pref change
a40bf2d 
Other changes:

* Fix #2370, unset deviceId pref set by old addon.

* Update Promise rejection / Error handling to match behavior
  documented in the addons-related Gecko code.
jaredhirsch pushed a commit that referenced this issue Mar 18, 2017
@ianb @jaredhirsch
Fix #2332, fix #2333: toggle webextension on pref change
e229976 
Other changes:

* Fix #2370, unset deviceId pref set by old addon.

* Update Promise rejection / Error handling to match behavior
  documented in the addons-related Gecko code.
jaredhirsch pushed a commit that referenced this issue Mar 18, 2017
@ianb @jaredhirsch
Fix #2332, fix #2333: toggle webextension on pref change
ca581ef 
Other changes:

* Fix #2370, unset deviceId pref set by old addon.

* Update Promise rejection / Error handling to match behavior
  documented in the addons-related Gecko code.
jaredhirsch pushed a commit that referenced this issue Mar 18, 2017
@ianb @jaredhirsch
Fix #2332, fix #2333: toggle webextension on pref change
229a930 
Other changes:

* Fix #2370, unset deviceId pref set by old addon.

* Update Promise rejection / Error handling to match behavior
  documented in the addons-related Gecko code.
jaredhirsch pushed a commit that referenced this issue Mar 18, 2017
@ianb @jaredhirsch
Fix #2332, fix #2333: toggle webextension on pref change
a7ca371 
Other changes:

* Fix #2370, unset deviceId pref set by old addon.

* Update Promise rejection / Error handling to match behavior
  documented in the addons-related Gecko code.
@ianb ianb closed this as completed in b28d687 Mar 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jaredhirsch jaredhirsch

Labels
None yet
Projects
None yet
Milestone
General Release 55
Development

No branches or pull requests
2 participants
@ianb @jaredhirsch