Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Firefox Screenshots pages are wrongly rendered on Internet Explorer browser #2516

Closed
SoftVision-CosminMuntean opened this issue Mar 29, 2017 · 6 comments
Assignees
Milestone

Comments

@SoftVision-CosminMuntean
Copy link

SoftVision-CosminMuntean commented Mar 29, 2017

[Affected versions]:

  • Internet Explorer 11
  • Page Shot 5.2.10545

[Affected Platforms]:

  • All Windows

[Steps to reproduce]:

  1. Open the Internat Explorer browser.
  2. Navigate to a someone else's shot (https://pageshot.dev.mozaws.net/DkwWKUqnYZqq8asG/www.amazon.com).
  3. Observe the shot details page.
  4. In a new tab navigate to "My Shots" page (https://pageshot.dev.mozaws.net/shots).
  5. Observe the "My Shots" page.

[Expected result]:

  • The pages are correctly rendered.

[Actual result]:
3. The footer links and the shot image are wrongly positioned on the page.
5. The footer links are wrongly positioned on the page.

[Notes]:

  • Here are two screen shots with the issue:
    ie1
    ie2
@johngruen
Copy link
Contributor

Actual action here is to look up automated UI testing

@johngruen johngruen modified the milestones: 55.1, General Release 55 Jun 12, 2017
@jaredhirsch jaredhirsch self-assigned this Jun 12, 2017
@jaredhirsch
Copy link
Member

Assigning myself to verify this error still occurs with new UX

@jaredhirsch
Copy link
Member

Yup, error still occurs in IE 11 / win 10.

Looks like .clip-container has 0 height.

I think this is philipwalton/flexbugs#58; changing the flex shorthand on .clip-container to flex: 0 auto, as mentioned in that bug, does fix the bug on IE. I don't see any breakage introduced by tweaking the flex shorthand, but turning over to @johngruen to investigate further.

@jaredhirsch
Copy link
Member

Also, note that modern.ie does still exist, so everyone can enjoy these quirky M$ bugs: https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/

@jaredhirsch jaredhirsch assigned johngruen and unassigned jaredhirsch Jun 12, 2017
@jaredhirsch
Copy link
Member

I"ll just open a PR with the CSS change and john can review

@jaredhirsch jaredhirsch assigned jaredhirsch and unassigned clouserw and johngruen Jun 21, 2017
@ianb ianb closed this as completed in 33d2ae5 Jun 27, 2017
ianb added a commit that referenced this issue Jun 27, 2017
Fix #2516; Tweak flex syntax so shot pages work on IE 11
@SoftVision-CosminMuntean
Copy link
Author

I have retested this issue and the Screenshots pages are better rendered. But, the footer links doesn't have a fixed position and the image is not displayed on the center of the page.

Here is a screenshot with the issue:
ie

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants