Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

webext review changes: shared/shot.js #2593

Closed
jaredhirsch opened this issue Apr 7, 2017 · 3 comments
Closed

webext review changes: shared/shot.js #2593

jaredhirsch opened this issue Apr 7, 2017 · 3 comments
Assignees
@chenba
Labels
code quality Not a bug, targeted for fixing in 2018 code Code quality issue, that does not have any outward effect on the product firefox Something that has to ship in the add-on in Firefox
Milestone
Sprint 8 (61-0) 😮

Comments

@jaredhirsch
Copy link
Member

jaredhirsch commented Apr 7, 2017 •
edited by ianb
Loading

refs #2591

shared/shot.js: deepEqual function changes, makeUuid changes, asJson vs toJson (all kinda scary and not clear we have to change them before uplift)
@jaredhirsch jaredhirsch mentioned this issue Apr 7, 2017
Merged
@jaredhirsch
Copy link
Member Author

feel free to just push fixes for this to the webextension-review-changes branch

@ghost ghost added this to the Stretch milestone Apr 7, 2017
@ianb
Copy link
Contributor

ianb commented Apr 10, 2017

@6a68: I don't know what deepEqual refers to here? I don't see a reference to that in #2471

@ianb ianb added code Code quality issue, that does not have any outward effect on the product firefox Something that has to ship in the add-on in Firefox labels Jan 10, 2018
@ianb ianb added the code quality Not a bug, targeted for fixing in 2018 label Jan 17, 2018
@chenba
Copy link
Collaborator

chenba commented Mar 13, 2018

@6a68 do you remember what about deepEqual that needed fixing?

@chenba chenba self-assigned this Mar 13, 2018
chenba added a commit to chenba/screenshots that referenced this issue Mar 14, 2018
@chenba
Rename asJson to toJSON. (mozilla-services#2593)
a2ecd83
@chenba chenba mentioned this issue Mar 14, 2018
Merged
ianb added a commit that referenced this issue Mar 14, 2018
@ianb
Merge pull request #4221 from chenba/2593-asJson-toJSON
17ca72b 
Rename asJson to toJSON. (#2593)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chenba chenba

Labels
code quality Not a bug, targeted for fixing in 2018 code Code quality issue, that does not have any outward effect on the product firefox Something that has to ship in the add-on in Firefox
Projects
None yet
Milestone
Sprint 8 (61-0) 😮
Development

No branches or pull requests
4 participants
@ianb @jaredhirsch @chenba @johngruen