Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

[Annotations] The "Save" button is not working #3405

Closed
SoftVision-CosminMuntean opened this issue Aug 25, 2017 · 5 comments
Closed

[Annotations] The "Save" button is not working #3405

SoftVision-CosminMuntean opened this issue Aug 25, 2017 · 5 comments
Assignees
Labels
P2 [QA]:Verified fixed Label for QA to mark verified fixed issues

Comments

@SoftVision-CosminMuntean

[Affected versions]:

  • Nightly 57.0a1
  • Screenshots 17.0.1895

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]:

  • The "xpinstall.signatures.required" boolean pref is set to "false".
  • Have a custom Screenshots dev build installed on a clean Firefox profiles.

[Steps to reproduce]:

  1. Start the browser with the profile from prerequisites and navigate to any website.
  2. Click the Screenshots icon from browser toolbar and save a selection on the page.
  3. Click the "Edit Image" button.
  4. Edit the image and click the "Save" button.
  5. Observe the browser behavior.

[Expected result]:

  • The edited image is successfully saved.

[Actual results]:

  • Nothing happens.

[Notes]:

  • Here is a screen recording with the issue:
    save edited
  • Here is a screen shot with browser console errors:
    save error
@johngruen johngruen added the P2 label Aug 28, 2017
@johngruen johngruen added this to the General Release 57 milestone Aug 28, 2017
@ghost ghost modified the milestones: General Release 57, Launch 58 Sep 21, 2017
@johngruen johngruen modified the milestones: Bucket ☕️, Backlog Oct 31, 2017
@chenba
Copy link
Collaborator

chenba commented Nov 1, 2017

Is this still a bug? I've been able to save annotated images.

@SoftVision-CosminMuntean
Copy link
Author

SoftVision-CosminMuntean commented Nov 1, 2017

I can still reproduce this issue using Screenshots dev 23.0.0 version installed from here: https://screenshots.dev.mozaws.net/homepage/install-test-local.html

When I click the "Save" button I get the following error:
save

@ghost ghost modified the milestones: Backlog, Sprint 2 (59-1) 🚌 Nov 9, 2017
@ianb
Copy link
Contributor

ianb commented Nov 27, 2017

This needs to be verified in dev: https://screenshots.dev.mozaws.net/homepage/install-test-local.html

@ianb ianb reopened this Nov 27, 2017
@SoftVision-CosminMuntean
Copy link
Author

The "Save" button seems to work, but the image is no longer displayed in "Edit" mode and the it's wrongly saved. I have logged this issue in #3848.
I will verify again this issue after #3848 will be fixed, to make sure that the "Save" functionality works as expected.

@ghost ghost modified the milestones: Sprint 2 (59-1) 🚌, Sprint 4 (59-3) 😯 Dec 18, 2017
@SoftVision-CosminMuntean
Copy link
Author

I have retested this issue on latest Screenshots 28.0.0 dev version and is no longer reproducible. The "Save" button works and the image is displayed.

@SoftVision-CosminMuntean SoftVision-CosminMuntean added the [QA]:Verified fixed Label for QA to mark verified fixed issues label May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

No branches or pull requests

5 participants