Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

[Annotations] The image is no longer displayed in "Edit" mode #3848

Closed
SoftVision-CosminMuntean opened this issue Nov 28, 2017 · 3 comments
Closed
Assignees
Labels
[QA]:Verified fixed Label for QA to mark verified fixed issues

Comments

@SoftVision-CosminMuntean

[Affected versions]:

  • Nightly 59.0a1
  • Screenshots 26.0.0

[Affected Platforms]:

  • All Windows
  • All Mac OS
  • All Linux

[Prerequisites]:

  • The "xpinstall.signatures.required" boolean pref is set to "false".
  • The "extensions.legacy.enabled" boolean pref is set tot "true".
  • Have the Screenshots 26.0.0 dev version installed from here, on a new clean profile.

[Steps to reproduce]:

  1. Open Firefox browser with the profile from prerequisites.
  2. Navigate to any website and save a selection.
  3. Click the "Edit" button and observe the image.

[Expected result]:

  • The image is correctly displayed.

[Actual result]:

  • The image is no longer displayed.

[Notes]:

  • Here is a screen recording with the issue:
    in edit mode image not displayed
@SoftVision-CosminMuntean
Copy link
Author

This issue is still reproducible using the latest Screenshots 26.0.0 dev version installed from here: https://screenshots.dev.mozaws.net/homepage/install-test-local.html
Tested on Windows 7, Mac Os 10.12 and Arch Linux.

@chenba
Copy link
Collaborator

chenba commented Dec 8, 2017

I branched off an earlier master rev where the canvas img crossOrigin attribute was set to "Anonymous"; another patch was merged into master set the attribute to "use-credentials". #3906 will change the attribute back.

@ghost ghost modified the milestones: Sprint 2 (59-1) 🚌, Sprint 4 (59-3) 😯 Dec 18, 2017
@ianb ianb closed this as completed in #3906 Jan 3, 2018
@SoftVision-CosminMuntean
Copy link
Author

I have retested this issue on latest Screenshots 27.0.0 dev version and is no longer reproducible. Tested on Mac, Linux and Windows. Marking this as verified.

@SoftVision-CosminMuntean SoftVision-CosminMuntean added the [QA]:Verified fixed Label for QA to mark verified fixed issues label May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

No branches or pull requests

4 participants