Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Handle not found in servershot #3776

Closed
ianb opened this issue Nov 14, 2017 · 0 comments
Closed

Handle not found in servershot #3776

ianb opened this issue Nov 14, 2017 · 0 comments
Assignees
Labels
code quality Not a bug, targeted for fixing in 2018 code Code quality issue, that does not have any outward effect on the product ✿sentry✿ Something related to an error report in our Sentry error collector
Milestone

Comments

@ianb
Copy link
Contributor

ianb commented Nov 14, 2017

Per this report it looks like we assume a database result exists when it may not: https://github.com/mozilla-services/screenshots/blob/master/server/src/servershot.js#L626

Also: https://github.com/mozilla-services/screenshots/blob/master/server/src/servershot.js#L664

@ianb ianb added the ✿sentry✿ Something related to an error report in our Sentry error collector label Nov 14, 2017
@ghost ghost added this to the Stretch milestone Nov 15, 2017
@ianb ianb added code Code quality issue, that does not have any outward effect on the product code quality Not a bug, targeted for fixing in 2018 labels Jan 10, 2018
@jaredhirsch jaredhirsch self-assigned this Feb 13, 2018
@chenba chenba closed this as completed in 4604edb Feb 13, 2018
chenba added a commit that referenced this issue Feb 13, 2018
Fix #3776 - Ensure DB returned rows before trying to access them
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
code quality Not a bug, targeted for fixing in 2018 code Code quality issue, that does not have any outward effect on the product ✿sentry✿ Something related to an error report in our Sentry error collector
Projects
None yet
Development

No branches or pull requests

2 participants