Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

[Annotation] There is no icon for the "Clear" button #3897

Closed
SoftVision-CosminMuntean opened this issue Dec 7, 2017 · 2 comments
Closed
Assignees
Labels
[QA]:Verified fixed Label for QA to mark verified fixed issues

Comments

@SoftVision-CosminMuntean

[Affected versions]:

  • Nightly 59.0a1
  • Screenshots 26.0.0 dev

[Affected Platforms]:

  • All Windows
  • All Mac OS
  • All Linux

[Prerequisites]:

  • The "xpinstall.signatures.required" boolean pref is set to "false".
  • The "extensions.legacy.enabled" boolean pref is set tot "true".
  • Have the Screenshots 26.0.0 dev version installed from here, on a new clean profile.

[Steps to reproduce]:

  1. Open latest Nightly build with the profile from prerequisites and navigate to any website.
  2. Save a selection on the page and click the "Edit this image" button.
  3. Observe the "Clear" button.

[Expected result]:

  • There is an icon on the "Clear" button.

[Actual result]:

  • There is no icon on the "Clear" button.

[Notes]:

  • Here is a screen shot with the issue:
    clear
@ghost ghost added this to the Sprint 2 (59-1) 🚌 milestone Dec 7, 2017
@chenba chenba self-assigned this Dec 8, 2017
@chenba
Copy link
Collaborator

chenba commented Dec 8, 2017

There are four svgs that are no longer displayable after the patch for #3063. Although reset.svg is more special: it works pre-svgo, but not displayable in Firefox post-svgo, yet works in Chrome.

@SoftVision-CosminMuntean
Copy link
Author

I have retested this issue on latest Screenshots 27.0.0 dev version and now the icon is correctly displayed. Tested on Mac, Linux and Windows. Marking this as verified.

@SoftVision-CosminMuntean SoftVision-CosminMuntean added the [QA]:Verified fixed Label for QA to mark verified fixed issues label May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

No branches or pull requests

2 participants